Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test codejail on Ubuntu 22.04 #186

Closed
2 tasks done
Tracked by #377
feanil opened this issue Aug 14, 2024 · 8 comments
Closed
2 tasks done
Tracked by #377

Test codejail on Ubuntu 22.04 #186

feanil opened this issue Aug 14, 2024 · 8 comments
Assignees
Labels
maintenance Routine upkeep necessary for the health of the platform

Comments

@feanil
Copy link
Contributor

feanil commented Aug 14, 2024

This repository is using Ubuntu 20.04 for testing. That version of Ubuntu will be out of support before Teak. Therefore this repo needs to be updated to testing with Ubuntu 22.04 before Sumac is cut to allow everyone sufficient time to switch to the new version.

Update this repository to test with Ubuntu 22.04 so that we can make the switch.

  • Tests are run and passing on Ubuntu 20.04 and 22.04
  • If major changes were needed and this is a library, a new version is published to PyPI or NPM

Note: In some cases, it may not make sense to test with both the old and the new version. For example, if the workflow is running linting or publishing to a package manager. In these cases, simply update the workflow to run on the newer version or opt to set it to ubuntu-latest instead if it doesn't matter what version it's running on. If you're unsure, reach out to the maintenance working group in #wg-maintenance in slack for guidance.

Known affected workflow files:

  • .github/workflows/ci.yml
  • .github/workflows/pypi-release.yml
@feanil feanil added the maintenance Routine upkeep necessary for the health of the platform label Aug 14, 2024
@MoisesGSalas MoisesGSalas self-assigned this Aug 15, 2024
@feanil
Copy link
Contributor Author

feanil commented Sep 20, 2024

@MoisesGSalas what's the state of this ticket, will you be able to complete it before the Sumac cut (Oct 23) or do you need more help to be able to land it by then?

@MoisesGSalas
Copy link
Contributor

Hi @feanil, I will be working on this this week. I opened #193 just to see a CI run and got a few errors.

If by the end of the week I'm facing any troubles I will ask for help.

@feanil
Copy link
Contributor Author

feanil commented Sep 24, 2024

@MoisesGSalas ideally, we should run tests on both Ubuntu 22.04 and 24.04 so that people can use either and we can be sure that codejail will work properly in them.

@MoisesGSalas
Copy link
Contributor

Hi @feanil, I've been having trouble with apparmor in newer ubuntus, do you know how can I ask for help?

In ubuntu >= 22.04 I've noticed some of the checks are failing (the sandbox binary can spawn children proceses and can access the network). I tried comparing the profiles used on newer versions but didn't find anything useful. I guess the biggest change would be the version of apparmor itself (2.x in Focal, 3.x in Jammy and 4.x in Noble)?

@feanil
Copy link
Contributor Author

feanil commented Oct 2, 2024

Hi @MoisesGSalas I can take a look at that. I've fought with this system enough times 😂

@feanil
Copy link
Contributor Author

feanil commented Oct 22, 2024

We're not all the way to 24.04 but #201 added support for 22.04, further investigation will be needed to add 24.04 support.

@feanil feanil changed the title Test codejail on Ubuntu 24.04 Test codejail on Ubuntu 22.04 Oct 23, 2024
@feanil
Copy link
Contributor Author

feanil commented Oct 23, 2024

@MoisesGSalas I've updated this ticket to be for 22.04 support. Can you create a separate ticket for adding 24.04 support and spend some time on that in the next few weeks, perhaps you'll have some luck with it, I can also spend some time on it but given how tricky it was to debug, it would be great if you can also take a look at it.

@feanil
Copy link
Contributor Author

feanil commented Oct 23, 2024

The 22.04 support was added as a part of #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Routine upkeep necessary for the health of the platform
Projects
None yet
Development

No branches or pull requests

2 participants