-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pypi-publish master branch sunset #180
Conversation
As it mentioned in the gh-action-pypi-publish repo, the master branch version has been sunset and we should use release/v1.
Thanks for the pull request, @CodeWithEmad! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@MoisesGSalas ci jobs failed due to an aws credentials issue. can you take a look? |
Hi @feanil, can you give me a hand with this one? |
Taking a look. |
@MoisesGSalas I ended up making #182 to get the test to run. The AWS credentials are not shared with forked PRs so I made a copy of the PR within the repo and it looks good. Longer term it wold be great if @MoisesGSalas, you, could look to see if we can replace the aws infra tests with standard github infrastructure. |
Thanks a lot @CodeWithEmad. I merged the PR that Feanil opened that includes this change, hope you don't mind. |
@CodeWithEmad Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This will fix the warning of 'The master branch version has been sunset for gh-action-pypi-publisher'