Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Support mongosh #1265

Closed

Conversation

DanielVZ96
Copy link

Description

The mongo CLI utility is being deprecated in 5.0 and fully removed in mongo 6.0, and replaced with mongosh. This PR adds mongosh compatibility and also adds upgrade scripts up to 7.0.

Testing

  • Run the upgrade_mongo_5_0.sh scripts up until upgrade_mongo_7_0.sh.
  • Make sure LMS and CMS works smoothly.

I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 31, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @DanielVZ96! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@DanielVZ96 DanielVZ96 mentioned this pull request Jan 31, 2024
@DanielVZ96
Copy link
Author

Test provisioning fails because it can't install google-cloud-sdk


No apt package "google-cloud-sdk", but there is a snap with that name.
Try "snap install google-cloud-sdk"

E: Unable to locate package google-cloud-sdk

@dianakhuang
Copy link
Contributor

@DanielVZ96 the latest versions of devstack remove that call, so you might just need to rebase off the most version of devstack to get rid of it: #1190

#!/usr/bin/env bash
set -eu -o pipefail

# This script will upgrade a devstack that was previosly running Mongo DB 4.0 to MongoDB 4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version in the comment is out of date on the upgrade scripts.

Suggested change
# This script will upgrade a devstack that was previosly running Mongo DB 4.0 to MongoDB 4.0
# This script will upgrade a devstack that was previosly running Mongo DB 4.x to MongoDB 5.x

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 16, 2024
@DanielVZ96 DanielVZ96 requested a review from timmc-edx February 17, 2024 03:51
@DanielVZ96 DanielVZ96 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 17, 2024
@DanielVZ96
Copy link
Author

DanielVZ96 commented Feb 17, 2024

@dianakhuang thanks for the tip! I cherry picked the fix, let me know if you want a different order for the commits.

@timmc-edx I updated the comments

Edit: I'm a bit stuck on getting CI running. I've been making slow progress but now LMS fails the healthcheck

> curl --fail -L http://localhost:18130/health/
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (56) Recv failure: Connection reset by peer
Attaching to edx.devstack.ecommerce
make: *** [Makefile:386: dev.check.ecommerce+lms] Error 2

Successful checks: lms_volume
Failed checks: lms_heartbeat studio_heartbeat ecommerce_heartbeat
Check result: FAILURE

@DanielVZ96 DanielVZ96 force-pushed the dvz/support-mongosh branch 8 times, most recently from 8c3f354 to 1703e9d Compare February 17, 2024 05:41
@itsjeyd
Copy link

itsjeyd commented Feb 22, 2024

Hey @DanielVZ96, just to clarify, would you like to get more input from your reviewers on the CI issue that you mentioned above? Or were you just giving an update about what you're currently working on?

The answer to that question will determine whether or not it's appropriate for this PR to be labeled as waiting on author for now :)

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 22, 2024
@DanielVZ96 DanielVZ96 changed the base branch from open-release/palm.master to master February 28, 2024 03:11
@DanielVZ96 DanielVZ96 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 28, 2024
@DanielVZ96
Copy link
Author

@itsjeyd at first I wanted more input, but now I just rebased my branch to master and started working from there.

@Agrendalath
Copy link

We can close this, as the devstack repo should be archived soon.

@openedx-webhooks
Copy link

@DanielVZ96 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants