Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Fix broken url for testing instructions. #1208

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

RafayGhafoor
Copy link
Contributor


I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 14, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @RafayGhafoor! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@RafayGhafoor
Copy link
Contributor Author

@robrap, Please review.

Fixes broken url found in the docs.
@RafayGhafoor RafayGhafoor requested a review from robrap October 16, 2023 16:21
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@RafayGhafoor
Copy link
Contributor Author

@robrap, I don't have the option to merge this PR, can you please do it. Thank you.

@robrap robrap merged commit 321f279 into openedx-unsupported:master Oct 16, 2023
3 of 4 checks passed
@openedx-webhooks
Copy link

@RafayGhafoor 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@RafayGhafoor RafayGhafoor deleted the patch-1 branch October 16, 2023 16:33
@robrap
Copy link
Contributor

robrap commented Oct 16, 2023

Thanks again @RafayGhafoor. I just needed to wait for tests to complete. Note that I squashed using the github UI, but otherwise that would be something you might need to do on other PRs.

@RafayGhafoor
Copy link
Contributor Author

yes, I understand @robrap. I also made this PR from the UI and it wasn't allowing me to squash since I am not a maintainer I guess.

@robrap
Copy link
Contributor

robrap commented Oct 16, 2023

I think you can only "Squash and Merge" through the UI. So otherwise, you'd need to get your fork locally and squash and push the changes back up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants