Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serlo scraper: needs an items filter #10

Open
AOHPI opened this issue Aug 4, 2020 · 2 comments
Open

Serlo scraper: needs an items filter #10

AOHPI opened this issue Aug 4, 2020 · 2 comments

Comments

@AOHPI
Copy link

AOHPI commented Aug 4, 2020

The current results of Serlo metadata are showing too much of organizational stuff, which is not relevant for any lessons. (Although the information might be interesting itself.)

Recommended fix: implement a filter based on the keywords, because thats the place where you can tell.

@torsten-simon
Copy link
Contributor

You might simply handle this yourself in the spider by overriding the shouldImport(self, response) method and return false or true depending whether you want to import the specific object. Or did I miss something?

@MRuecklCC
Copy link

Can we close this as won't fix / outdated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants