Document and modify accessibility vocabulary #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lummerland
reviewed
Jul 19, 2022
| <b> a skos:Concept ; | ||
| skos:prefLabel "B" ; | ||
| skos:definition "The content does not comply to the WCAG A rating requirements."@en ; | ||
| skos:definition "Der Inhalt erfüllt nicht die WCAG Anforderungen für eine A-Wertung."@en ; |
lummerland
reviewed
Jul 19, 2022
| <none> a skos:Concept ; | ||
| skos:prefLabel "Nicht geprüft"@de ; | ||
| skos:prefLabel "Not tested"@en ; | ||
| <b> a skos:Concept ; |
There was a problem hiding this comment.
Maybe instead of just "b" something more meaningful? E.g. "failed" :D
|
Regarding the change of identifiers I strongly suggest to talk to @torsten-simon The identifiers are just ...identifiers, so I'm not sure if we really need to change them. If changed, this might have implications on already assigned values and a migration has to be run. Other than that I approve the description changes, just the language has to be adjusted as @lummerland suggested. |
|
If we change any current identifiers, I need a mapping from the old to the new id in order to map existing content. I'm not sure if "meaningful" identifiers are that important, afaik we use uuid identifiers for newer vocabs which might do the job just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this a proposal to resolve #18 please :)
Changes:
noneandWCAGconcept.narrowerrelations between concepts to indicate orderingbitvconcept intobitv-Iandbitv-IIDiscussion highly appreciated!