Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"/collections/{node_id}/tree endpoint structure improvement #86

Open
MRuecklCC opened this issue Aug 9, 2022 · 0 comments
Open

"/collections/{node_id}/tree endpoint structure improvement #86

MRuecklCC opened this issue Aug 9, 2022 · 0 comments
Labels
API Changes that require modifications of the REST API quality Improvements in code quality and organization that do not have a visible effect to the enduser

Comments

@MRuecklCC
Copy link
Collaborator

Currently, the "/collections/{node_id}/tree endpoint returns a list of Nodes:

image

There are two issues with that:

  • The parent_id fields of child nodes are null.

    They should either hold the uuid of their respective parent, or even better, we could just remvove the field, as it is redundant in the first place.

  • Instead of returning a List[Node] we should simply return a singular Node.

    This makes it more clear, that all returned elements form a subtree of the queried toplevel node and unifies the datastructures.

@MRuecklCC MRuecklCC changed the title "/collections/{node_id}/tree endpoint structure improvement. "/collections/{node_id}/tree endpoint structure improvement Aug 11, 2022
@MRuecklCC MRuecklCC added quality Improvements in code quality and organization that do not have a visible effect to the enduser API Changes that require modifications of the REST API labels Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes that require modifications of the REST API quality Improvements in code quality and organization that do not have a visible effect to the enduser
Projects
None yet
Development

No branches or pull requests

1 participant