-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align frontend data model with Metadata names of edusharing service. #94
Comments
As part of this it may also make sense to simplify the API input and output models. After some discussion with @RMeissnerCC we decided to:
|
The simplifications of the API data model was done as part of #100. |
Is there now anything left in this issue or can it be closed? |
The main issue is still unresolved: https://issues.edu-sharing.net/jira/browse/KBMBF-475 |
To make some progress on this front, i spent a while going through the current meta data fields defined by the edusharing service and checking them out in elasticsearch. A couple of those fields are: Misc attributes
Quality attributes
Available ExtractorsOn the other side, we have the current extractor implementations:
|
Mapping between extractors and meta data fieldsAs a first step, the following relations come to mind:
|
Given the example of the Consider the following two scenarios, where the service receives a request to extract meta information for a website that contains adult advertisement.
Similar arguments can be made for other attributes. In those cases, the response data model for those cases could be either
In abstract terms:
In both cases we could refrain from responding with an assessment or at least wrap it into a "maybe"/"potentially" |
Regarding your latest comment: so basically, there is no safe way of using black-/whitelists and make a solid statement. All we say is based on us relying on the lists to be "complete", whatever that means |
I read about accessibility ratings and lighthouse
|
It looks as we need to discuss and decide more ore less every field and mapping because of special characteristics. I think it would be helpful to have more detailed information on top of the "simple" mapping of fields. E.g.
|
As a first shot I will provide a new API endpoint providing the following 4 attributes:
The structure will follow what is available on the The endpoint will be {
"url":"https://some-domain.de/path/to/content.html"
} For now, the endpoint will only provide results for html content. Responses for non html content is unspecified for now. {
"ccm:oeh_quality_protection_of_minors": {
"stars": 0-5, # may be missing. In that case there will be an exception message
"explanation": "some human readable string",
"error": "" # will only be present if extraction failed, in which case neither stars, explanation or extra will be available.
"extra": {
# attribute specific extra information. the structure depends on the attribute.
},
"ccm:oeh_quality_login": {
# same as above
},
"ccm:oeh_quality_data_privacy": {
# same as above
},
"ccm:accessibilitySummary": {
# same as above
}
} |
Currently, the data model uses its own names for the different extractors. Eventually we want to align the names of the extractors to comply with the edusharing naming conventions?
The text was updated successfully, but these errors were encountered: