From fa2daab7217751dcd2bcf75bec059858ebd47c41 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jiri=20Dan=C4=9Bk?= Date: Wed, 27 Nov 2024 14:45:03 +0100 Subject: [PATCH] review suggestion, fix comment in tests --- .../controllers/notebook_controller_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/components/odh-notebook-controller/controllers/notebook_controller_test.go b/components/odh-notebook-controller/controllers/notebook_controller_test.go index 01b2a4c10a1..2908b7fae9b 100644 --- a/components/odh-notebook-controller/controllers/notebook_controller_test.go +++ b/components/odh-notebook-controller/controllers/notebook_controller_test.go @@ -455,9 +455,9 @@ var _ = Describe("The Openshift Notebook controller", func() { }, From: []netv1.NetworkPolicyPeer{ { - // Since for unit tests we do not have context, - // namespace will fallback to test pod namespace - // if run in CI or `redhat-ods-applications` if run locally + // Since for unit tests the controller does not run in a cluster pod, + // it cannot detect its own pod's namespace. Therefore, we define it + // to be `redhat-ods-applications` (in suite_test.go) NamespaceSelector: &metav1.LabelSelector{ MatchLabels: map[string]string{ "kubernetes.io/metadata.name": testPodNamespace,