Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classify landcover level34 by class def and code csv #174

Merged
merged 8 commits into from
Nov 28, 2024
Merged

Conversation

emmaai
Copy link
Contributor

@emmaai emmaai commented Nov 27, 2024

As the title, the functionality of level34 classification was rewritten to read the csv ( https://dea-public-data-dev.s3-ap-southeast-2.amazonaws.com/lccs_validation/c3/data_to_plot/lccs_colour_scheme_golden_dark_au_c3.csv) and generate the conditions and then the class code accordingly.
A decision tree was generated based on the same csv:

config will be used by level34 plugin
https://github.com/GeoscienceAustralia/dea-config/blob/landcover_l4/dev/services/odc-stats/lccs/ga_ls_landcover_class_cyear_3.yaml

@emmaai emmaai requested review from JM-GA and tebadi November 27, 2024 05:12
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 95.88235% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.24%. Comparing base (caa72ff) to head (d58b0c0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
odc/stats/plugins/lc_level34.py 88.37% 5 Missing ⚠️
odc/stats/plugins/_utils.py 97.95% 1 Missing ⚠️
tests/test_lc_level34.py 98.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
- Coverage    82.67%   81.24%   -1.44%     
===========================================
  Files           65       50      -15     
  Lines         4855     4532     -323     
===========================================
- Hits          4014     3682     -332     
- Misses         841      850       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmaai emmaai changed the title fix typo on class code in landcover level4 classify landcover level34 by class def and code csv Nov 27, 2024
@emmaai emmaai requested review from tebadi and JM-GA November 27, 2024 12:20
@emmaai emmaai merged commit 7e56476 into develop Nov 28, 2024
10 checks passed
@emmaai emmaai deleted the fix_l34_typo branch November 28, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants