Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cultivated aggregation logic and make sensor choice an option #165

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

emmaai
Copy link
Contributor

@emmaai emmaai commented Nov 6, 2024

Changes:

  • the logic of cultivated changed from any sensor says cultivated -> cultivated to any sensor says natural -> natural as bias towards cultivated class was observed in validation
  • sensor choice as an option for both cultivated and woody cover
  • woody cover band name aligned with official definition woody instead of woody_cover

Copy link
Contributor

@tebadi tebadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the impact on the accuracy of validation data been measured? Not sure we have data from different sensors in the validation but if we do, it's worth checking this.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 57.57576% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.25%. Comparing base (182de0d) to head (729e294).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
odc/stats/plugins/lc_ml_treelite.py 41.66% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #165      +/-   ##
===========================================
- Coverage    82.38%   82.25%   -0.14%     
===========================================
  Files           67       67              
  Lines         4951     4970      +19     
===========================================
+ Hits          4079     4088       +9     
- Misses         872      882      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmaai
Copy link
Contributor Author

emmaai commented Nov 6, 2024

Has the impact on the accuracy of validation data been measured? Not sure we have data from different sensors in the validation but if we do, it's worth checking this.

I have to merge this to be able to run another continental scale and then on validation data. There would be retrace potentially.

@emmaai emmaai merged commit 000f79b into develop Nov 7, 2024
5 checks passed
@emmaai emmaai deleted the cultivated_conserv branch November 7, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants