-
Notifications
You must be signed in to change notification settings - Fork 13
[Vote] Should we switch to predictable digest tags #65
Comments
Yes, switch to predictable tags. This includes the possible option to include the artifact type in the tag name. |
No, use unique tags, one per artifact. |
My own personal pro/con list:
Given those trade-offs, I'd prefer to push for better race condition handling in distribution-spec and in registry implementations, which leaves predictable tags as the better solution since discovering content doesn't require listing. |
Does anyone get to vote? I would say that race condition handling is worse than pagination, and that with pagination generally implemented using the So my vote would be a no, but I won't hit the button because I'm not a member of the WG :) |
Yep! Anyone can vote, go ahead and hit the button. |
I agree with Jason. We've used the predictable tags method in cosign for a while now, and while the race condition is real I can't recall anyone ever hitting it. I'd lean toward fixing that in the distribution-spec. I'd feel much differently if people were regularly running into the race condition. |
Thanks, I'm the only no vote but you know, doing my part for democracy :)
Dangerous way to think about race conditions, they're harmless until you hit them, then they're deadly (IMO). As artifacts get popular I can imagine many build processes will generate an image then spawn off multiple processes to sign etc which could easily start to race. By then we'd hopefully not be using the tags anymore though, so maybe it doesn't matter.
I think that's worth doing regardless! |
Is using the predictable tags dependent on fixing the race condition issue in the distribution spec? |
I wouldn't say "dependent" exactly (i.e., that we should block this decision on the outcome of opencontainers/distribution-spec#251), but that we expect questions about handling race conditions to be solved by distribution-spec, and not build workarounds for that in this spec. |
I suspect the reality will be inversed. We may approve a spec with a known race condition for existing registries. And new registries may fix race conditions, but they'll also add the new API to query referrers, negating the need to fix race conditions in this spec (fixing race conditions in distribution-spec still has value outside of this spec). |
Based on the vote alone, we are planning to go with the first option:
@sudo-bmitch to follow up with PR to clarify |
From today's meeting, we've decided to go with a single predictable tag. |
To pick a direction for #61 on whether we want to use predictable tags or use unique tags that require a tag listing to avoid race conditions, please vote on this issue. We'll leave this open for 1 week and move forward based on the results in the 2022-07-29 meeting. Vote by giving one of the below comments a thumbs up.
The text was updated successfully, but these errors were encountered: