Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runc init can't communicate with runc start #4402

Open
ningmingxiao opened this issue Sep 13, 2024 · 2 comments
Open

runc init can't communicate with runc start #4402

ningmingxiao opened this issue Sep 13, 2024 · 2 comments

Comments

@ningmingxiao
Copy link

ningmingxiao commented Sep 13, 2024

Description

runc init can't send message to runc start if use exec.fifo.

Steps to reproduce the issue

runc init can't send message to runc start if use exec.fifo.

Describe the results you received and expected

runc init can send message to runc start by using exec.sock

What version of runc are you using?

1.12

Host OS information

any kernel

Host kernel information

any

@ningmingxiao ningmingxiao changed the title change exec.fifo to exec.sock runc init can't send message to runc start Sep 13, 2024
@ningmingxiao ningmingxiao changed the title runc init can't send message to runc start runc init can't communicate with runc start Sep 13, 2024
@cyphar
Copy link
Member

cyphar commented Sep 13, 2024

I don't know what you're trying to do, but the point of using a FIFO is that it allows us to send a signal to runc init in a way that can't be missed and in a way that many runc start invocations will be a no-op (effectively, something like a pthread_barrier_t EDIT: actually, pthread_barrier_t doesn't work this way).

Many years ago we used to do this by sending signals, but signals can get lost or coalesced for a variety of reasons and you don't want to send signals to the actual container process (even if they are ignored by default for pid1).

A message-based scheme with a socket would struggle with being able to handle many runc starts AFAICS.

@ningmingxiao
Copy link
Author

I try to resolve this issue .
containers/crun#1562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants