RT 7.11: Updated the script with deviation for ASpath set #3365
+145
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11979252793Details
💛 - Coveralls |
dplore
requested changes
Sep 11, 2024
feature/bgp/policybase/otg_tests/aspath_and_community_test/aspath_and_community_test.go
Outdated
Show resolved
Hide resolved
| @@ -100,7 +103,6 @@ func configureImportBGPPolicy(t *testing.T, dut *ondatra.DUTDevice, ipv4 string, | |||
| cs = append(cs, oc.UnionString(communityMatch)) | |||
| } | |||
| communitySet.SetCommunityMember(cs) | |||
| communitySet.SetMatchSetOptions(commMatchSetOptions) | |||
There was a problem hiding this comment.
looks ok, I see it is moved into a separate, already accepted deviation in line 123.
| @@ -273,6 +276,10 @@ func TestCommunitySet(t *testing.T) { | |||
| bs := cfgplugins.NewBGPSession(t, cfgplugins.PortCount2, nil) | |||
| bs.WithEBGP(t, []oc.E_BgpTypes_AFI_SAFI_TYPE{oc.BgpTypes_AFI_SAFI_TYPE_IPV4_UNICAST, oc.BgpTypes_AFI_SAFI_TYPE_IPV6_UNICAST}, []string{"port2"}, true, true) | |||
|
|
|||
| if deviations.BgpAspathsetUnsupported(bs.DUT) { | |||
| testResults[4] = true | |||
There was a problem hiding this comment.
see above, we need some alternative configuration/policy to achieve the desired behavior of matching on as paths.
| @@ -90,7 +90,7 @@ functions. | |||
| * conditions/bgp-conditions/match-community-set/config/ | |||
| * community-set: "regex-community" | |||
| * match-set-options: "ANY" | |||
| * actions/config/policy-result = "NEXT_STATEMENT" | |||
| * actions/config/policy-result = "ACCEPT_ROUTE" | |||
| @@ -415,7 +449,14 @@ func configureImportExportMultifacetMatchActionsBGPPolicy(t *testing.T, dut *ond | |||
| t.Fatalf("AppendNewStatement(%s) failed: %v", matchAspathSetMedStatement, err) | |||
| } | |||
|
|
|||
| // TODO create as-path-set on the DUT, match-as-path-set not support. | |||
| // Configure my_aspath: [ "65512" ] to match_aspath_set_med statement | |||
| if !deviations.BgpAspathsetUnsupported(dut) { | |||
There was a problem hiding this comment.
There needs to be some alternative to using aspath to achieve similar behavior. Without this, I can't accept this deviation.
|
Fixes #3415 |
|
@s-nandu please let us know if you will be resolving the comments. |
s-nandu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RT 7.11: Updated the script with deviation for ASpath set
Added policy result as ACCEPT for policy "match_community_regex"
(Moved RT 7.4 to #3607 )