Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry update to the code #291

Merged
merged 8 commits into from
Sep 19, 2024
Merged

Sentry update to the code #291

merged 8 commits into from
Sep 19, 2024

Conversation

ADIMANV
Copy link
Contributor

@ADIMANV ADIMANV commented Sep 17, 2024

Pull Request

Description

Minor Update to the code which adds Sentry for a better error detection
Stems from the PR: openclimatefix/ocf-infrastructure#540

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

satip/app.py Outdated Show resolved Hide resolved
@peterdudfield
Copy link
Collaborator

Could you add SENTRY_DSN and ENVIRONMENT to https://github.com/openclimatefix/Satip/blob/main/README.md?plain=1#L96

@peterdudfield
Copy link
Collaborator

Looks good to go

@ADIMANV ADIMANV merged commit 188001c into main Sep 19, 2024
3 of 4 checks passed
@ADIMANV ADIMANV deleted the Sentry-Update branch September 19, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants