Add modals from Tobira #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the "Modal" component from Tobira. The component is ported with the minimum amount of required changes. Translations string will have to be provided in their translated form.
Adds another button component from Tobira, with the goal of using it in the confirmation modal from Tobira. The button can be normal, happy or danger.
As how it is in Tobira.
Adds a nice little error box from Tobira to render errors in. Also adds the card component which is required for that. Used by confirmation modal.
Adds the confirmation modal from tobira
Added missing colors, changed unused colors.
LukasKalbertodt
requested changes
May 28, 2024
There was a problem hiding this comment.
Thanks for making these available in appkit!
I left some comments of things I think should be changed still. Regarding the translations: I think its fine just passing all strings to the component for now. Figuring out how to get i18next into appkit and make it work nicely when included in an app... is too much work now. The vast majority of duplicate code will already be eliminated by this.
As suggested by @LukasKalbertodt. Thanks.
It is not necessary.
Move code over to button.tsx
Optional, defaults to "currentcolor".
Based on the advice by @LukasKalbertodt
We should not rely on a hook in a function working, so better let the calling component pass it.
LukasKalbertodt
requested changes
May 29, 2024
|
For some of the accent colors, inverting seems somewhat tricky, as their l value is close to 50%. What do you prefer from the two images below? (Both of the "Confirm" buttons are hovered.)
|
LukasKalbertodt
requested changes
May 29, 2024
LukasKalbertodt
approved these changes
May 29, 2024
Arnei
added a commit
to Arnei/opencast-editor
that referenced
this pull request
Jun 6, 2024
Fixes an issue with the upload subtitle button, where the automatic browser dialog used by the button would "time out", failing to open up the subsequent file dialog. This replaces it with a confirmation modal from appkit. WARNING: Requires opencast/appkit#5 to be merged and released!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ModalandConfirmationModalcomponents and their types to appkit. Also adds a bunch of other stuff from Tobira thatConfirmationModalin particular requires.Additionally:
Spinnercomponent.Points to consider: