Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icewind: fails if remote service is non-responsive #283

Open
pdowler opened this issue Aug 8, 2023 · 0 comments
Open

icewind: fails if remote service is non-responsive #283

pdowler opened this issue Aug 8, 2023 · 0 comments
Labels

Comments

@pdowler
Copy link
Member

pdowler commented Aug 8, 2023

2023-08-08 02:04:40.203[main] INFO  ObservationHarvester - harvest window: 2023-08-04 13:41:51.808 :: 2023-08-08 01:59:40.203 [100]
2023-08-08 02:04:44.215[main] FATAL Main - Unexpected failure
java.lang.RuntimeException: failed to get observation list
        at ca.nrc.cadc.caom2.repo.client.RepoClient.readObservationStateList(RepoClient.java:486) ~[caom2-repo-1.4.4.jar:?]
        at ca.nrc.cadc.caom2.repo.client.RepoClient.getObservationList(RepoClient.java:283) ~[caom2-repo-1.4.4.jar:?]
        at ca.nrc.cadc.caom2.repo.client.RepoClient.getList(RepoClient.java:293) ~[caom2-repo-1.4.4.jar:?]
        at org.opencadc.icewind.ObservationHarvester.doit(ObservationHarvester.java:288) ~[icewind.jar:?]
        at org.opencadc.icewind.ObservationHarvester.run(ObservationHarvester.java:193) ~[icewind.jar:?]
        at org.opencadc.icewind.CaomHarvester.run(CaomHarvester.java:195) ~[icewind.jar:?]
        at ca.nrc.cadc.auth.RunnableAction.run(RunnableAction.java:96) ~[cadc-util-1.9.6.jar:?]
        at java.security.AccessController.doPrivileged(Native Method) ~[?:?]
        at javax.security.auth.Subject.doAs(Subject.java:361) ~[?:?]
        at org.opencadc.icewind.Main.main(Main.java:224) ~[icewind.jar:?]
Caused by: java.net.SocketException: Connection reset

The same failure seen by the DeletionHarvester is logged but ignored. That's probably OK.

Expected behaviour: icewind should sleep and retry, with the sleep growing in length up to the max if failures are repeated.

Expected fixes:

  • RepoClient should identify this and throw a TransientException instead of a RuntimeException.
  • icewind should handle the TransientException and continue with it's normal sleep/loop
@pdowler pdowler added the bug label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant