Use openHPI-managed Tubesock fork #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSerth
added
bug
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2580 +/- ##
=======================================
Coverage 69.52% 69.52%
=======================================
Files 202 202
Lines 6370 6370
=======================================
Hits 4429 4429
Misses 1941 1941 ☔ View full report in Codecov by Sentry. |
|
We'll need to update the |
Dome-GER
approved these changes
Oct 11, 2024
Tubesock is outdated and should be replaced with ActionCable. For now, however, we simply patch the issues we've discovered.
MrSerth
force-pushed
the
tubesock_fork
branch
from
580e564
to
9f3df56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tubesock is outdated and should be replaced with ActionCable. For now, however, we simply patch the issues we've discovered.
I've created a custom fork, included some pending contributions and made additional suggestions.