Add schema validation and documentation for RemoteEvaluation #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2575 +/- ##
=======================================
Coverage 69.52% 69.52%
=======================================
Files 202 202
Lines 6360 6370 +10
=======================================
+ Hits 4422 4429 +7
- Misses 1938 1941 +3 ☔ View full report in Codecov by Sentry. |
MrSerth
force-pushed
the
remote_evaluation
branch
from
87f96e7
to
64254ab
Compare
For the spec, we had to change a few things: 1. The parameters are now required in the body. Rails usually merges body and query parameters, but we are now checking the request body only. 2. `format: :json` to parse the response received as JSON 3. `as: :json` to send the correct Content-Type with the request Those changes have no impact on the functionality of the actual controller under test.
MrSerth
force-pushed
the
remote_evaluation
branch
from
64254ab
to
48b4ace
Compare
When the runner is already in use, we do not want to request a new runner or try copying files again. Hence, this improvement is needed to avoid an invalid state or other errors.
MrSerth
force-pushed
the
remote_evaluation
branch
from
48b4ace
to
ad6d70a
Compare
Dome-GER
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two major changes, aiming to improve the robustness of usefulness of the remote evaluation: