Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple files in the synchronized editor #1868

Closed
MrSerth opened this issue Sep 1, 2023 · 0 comments · Fixed by #1866
Closed

Support multiple files in the synchronized editor #1868

MrSerth opened this issue Sep 1, 2023 · 0 comments · Fixed by #1866
Assignees
Labels
bug javascript Pull requests that update Javascript code

Comments

@MrSerth
Copy link
Member

MrSerth commented Sep 1, 2023

Currently, the delta is only applied to the first editor session. This will cause issues with exercises having multiple files, I assume.

The problematic line is:

this.editors[0].session.doc.applyDeltas([delta]);

There, every change is inserted into the first editor (identified by this.editors[0]).

In order to support multiple files, we should probably send the active file ID together with the delta and then insert the change in the respective editor.

@MrSerth MrSerth added bug javascript Pull requests that update Javascript code labels Sep 1, 2023
@MrSerth MrSerth linked a pull request Sep 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants