Add specs for OmniAuth::Strategies #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## omniauth_link #1318 +/- ##
=================================================
+ Coverage 88.80% 91.98% +3.18%
=================================================
Files 100 100
Lines 2376 2358 -18
=================================================
+ Hits 2110 2169 +59
+ Misses 266 189 -77 ☔ View full report in Codecov by Sentry. |
kkoehn
reviewed
Mar 27, 2024
MrSerth
force-pushed
the
specs_saml_strategies
branch
from
d6ac551
to
092f634
Compare
kkoehn
approved these changes
Apr 2, 2024
MrSerth
added a commit
that referenced
this pull request
Apr 2, 2024
MrSerth
added a commit
that referenced
this pull request
Apr 2, 2024
kkoehn
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Allow adding and removing OmniAuth account links * Allow OmniAuth users to perform changes to their account In order to allow changes, we disable the password requirement for those users. As soon as a password is set for OmniAuth users, the regular workflow requiring the current password is restored. * Prevent deletion of last OmniAuth identity * Add specs for OmniAuth::Strategies (#1318)
Melhaya
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Allow adding and removing OmniAuth account links * Allow OmniAuth users to perform changes to their account In order to allow changes, we disable the password requirement for those users. As soon as a password is set for OmniAuth users, the regular workflow requiring the current password is restored. * Prevent deletion of last OmniAuth identity * Add specs for OmniAuth::Strategies (#1318)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the SAML strategies included in the application still lacked some test coverage. With this PR, I am improving the test coverage.
Please note that this branch already includes the changes of #1316.