Add specs for User#avatar_format #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
+ Coverage 87.55% 87.73% +0.17%
==========================================
Files 99 99
Lines 2315 2315
==========================================
+ Hits 2027 2031 +4
+ Misses 288 284 -4 ☔ View full report in Codecov by Sentry. |
kkoehn
requested changes
Mar 27, 2024
MrSerth
force-pushed
the
specs_avatar_format
branch
from
f517ec5
to
4b6567f
Compare
Previously, an invalid image would still be displayed to users in an attempt to keep their changes. However, this didn't work, so that we are now preventing a changed image to be displayed.
MrSerth
force-pushed
the
specs_avatar_format
branch
from
4b6567f
to
ccdd4ea
Compare
Dome-GER
approved these changes
Apr 2, 2024
kkoehn
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1316, I got a few more tests suggested that I didn't want to remove (since none were present before).