Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributions: Consider visibility changes #1633

Open
2 tasks
MrSerth opened this issue Sep 2, 2024 · 0 comments
Open
2 tasks

Contributions: Consider visibility changes #1633

MrSerth opened this issue Sep 2, 2024 · 0 comments
Labels
enhancement ruby Pull requests that update Ruby code

Comments

@MrSerth
Copy link
Member

MrSerth commented Sep 2, 2024

For now, contributions can be started and viewed only when the corresponding base task is visible. Since groups only allow full memberships with writing permissions, this means a task must be public to allow contributions.

Per se, requiring a base task to be public is not a problem at all and the functionality works as expected. However, as soon as the visibility level is changed, the problem begins. In the current implementation, a change in visibility means: Contributors immediately loose access to their contributions. This is especially problematic, if the contribution is still pending.

We should investigate what needs to be done when the visibility level changes. For example, it could make sense to display a warning, deny changes to the visibility settings until all contributions were either accepted or rejected, or automatically decouple pending contributions.

When changing this, check:

  • scope :pending_contribution in app/models/task.rb
  • example TaskContributionPolicy when the user is logged in when the user is the contribution user when the original task is private in spec/policies/task_contribution_policy_spec.rb

Read more about the advantages and disadvantages here.

@MrSerth MrSerth added enhancement ruby Pull requests that update Ruby code labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ruby Pull requests that update Ruby code
Projects
None yet
Development

No branches or pull requests

1 participant