Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OmniAuth login: Add switch to control auto-update of attributes #1329

Open
MrSerth opened this issue Apr 2, 2024 · 0 comments
Open

OmniAuth login: Add switch to control auto-update of attributes #1329

MrSerth opened this issue Apr 2, 2024 · 0 comments
Labels
enhancement ruby Pull requests that update Ruby code

Comments

@MrSerth
Copy link
Member

MrSerth commented Apr 2, 2024

I know it was in there before, but do we actually want to force users to use their real names? A user created with this method is also unable to change anything in is profile, since it always requests a password for changes. (mainly affects the avatar right now)
If the user shouldn't change those attributes we could also make them readonly or similar, to make it clear.

Originally posted by @kkoehn in #1316 (comment)


I fixed the issue that prevented users created through OmniAuth to change their profile, especially their avatar.

The update of the said attributes (email, first_name, last_name) is not that trivial and I decided not to touch the behavior in this PR: What do you think a user would expect? Sure, manually updating would be nice. However, if the information (especially the email address) was updated upstream, it would also be nice to store the newest information transferred. Since we get this information on every login, we just assume it's the most current and desired information.

I can think of rarely complex update procedures if we want to change this assumption and behavior, but those are clearly out of scope for this PR.

Originally posted by @MrSerth in #1316 (comment)


I agree with it being out of scope, but my intuitive approach would be to add a switch, with which the user can control the auto-updating.

Originally posted by @kkoehn in #1316 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ruby Pull requests that update Ruby code
Projects
None yet
Development

No branches or pull requests

1 participant