Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert rm data from 1.4 to 2 and back #392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pieterbos
Copy link
Collaborator

TODO: replace archetype root node ids with the archetype id when converting to ADL 1.4. This is a destructive action though...

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #392 (96dc910) into master (c6dcbda) will increase coverage by 0.07%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #392      +/-   ##
============================================
+ Coverage     70.97%   71.05%   +0.07%     
- Complexity     6625     6646      +21     
============================================
  Files           645      647       +2     
  Lines         22031    22109      +78     
  Branches       3544     3558      +14     
============================================
+ Hits          15636    15709      +73     
- Misses         4709     4710       +1     
- Partials       1686     1690       +4     
Impacted Files Coverage Δ
...a/com/nedap/archie/rminfo/ArchieAOMInfoLookup.java 80.43% <0.00%> (-0.89%) ⬇️
.../java/com/nedap/archie/rminfo/ModelInfoLookup.java 45.00% <ø> (ø)
...va/com/nedap/archie/rminfo/ArchieRMInfoLookup.java 86.54% <66.66%> (-0.55%) ⬇️
...ain/java/com/nedap/archie/rminfo/RMTreeWalker.java 75.86% <75.86%> (ø)
.../java/com/nedap/archie/rmutil/RMADL2Converter.java 94.87% <94.87%> (ø)
...in/java/com/nedap/archie/aom/utils/NodeIdUtil.java 74.07% <100.00%> (+7.40%) ⬆️
.../com/nedap/archie/rm/integration/GenericEntry.java 33.33% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6dcbda...96dc910. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant