Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semconv for cli command executions #1577

Closed
xrmx opened this issue Nov 14, 2024 · 0 comments · Fixed by #1588
Closed

Semconv for cli command executions #1577

xrmx opened this issue Nov 14, 2024 · 0 comments · Fixed by #1588
Labels
area:new enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage

Comments

@xrmx
Copy link
Contributor

xrmx commented Nov 14, 2024

Area(s)

area:new

Is your change request related to a problem? Please describe.

Would be nice to formalize semantic conventions for cli command execution regarding span name, status and attributes.

Describe the solution you'd like

For the attributes we can reuse something from Process.

Describe alternatives you've considered

No response

Additional context

I'm implementing an instrumentation for the click library:

# hello.py
import click

@click.command()
def hello():
    click.echo('Hello World!')

if __name__ == '__main__':
    hello()

and you call them as python hello.py

This is also the underlying library used by flask where you can run the server itself, e.g. flask run or implement your own command, e.g. flask createuser myusername.

@xrmx xrmx added enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:new enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant