-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify system.cpu.state
, process.cpu.state
, container.cpu.state
into cpu.mode
?
#1139
Comments
/cc @open-telemetry/semconv-system-approvers |
system.cpu.state
and process.cpu.state
attributes?system.cpu.state
and process.cpu.state
and container.cpu.state
attributes?
system.cpu.state
and process.cpu.state
and container.cpu.state
attributes?system.cpu.state
, process.cpu.state
, container.cpu.state
into cpu.state
?
system.cpu.state
, process.cpu.state
, container.cpu.state
into cpu.state
?system.cpu.state
, process.cpu.state
, container.cpu.state
into cpu.mode
?
We have been evaluating this already at #1026 (issue) which currently blocked at #1026 (comment). Any particular reason for having |
Thanks!
No strong opinion, same concern as in #1128 (comment) - "I feel like state normally implies the ability to transition between different values which isn't true here." CPU state and CPU mode seem to be both used widely, but CPU mode would probably be more precise? (i.e. someone looking at the Also this (but we should all take it with a grain of salt)
They are still experimental. Also if we are renaming them anyway, let's consider changing state to mode as well. |
I'm going to close this as duplicate of #840. Let's continue the discussion on https://github.com/open-telemetry/semantic-conventions/pull/1026/files#r1635136959 |
process.cpu.state
process.cpu.state
system
;user
;wait
process.cpu.state
has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used.system
user
wait
system.cpu.state
system.cpu.state
idle
;interrupt
system.cpu.state
has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used.idle
interrupt
iowait
nice
steal
system
user
Could we unify them?
It could also be useful on runtime-specific metrics: #1035 (comment)
cpu.mode
cpu.mode
idle
;interrupt
cpu.mode
has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used.user
Only
user
because it seems to be the most common denominator. But effectively:process
,system
,container
,{runtime-specific}
semconv can document applicable valuesThe text was updated successfully, but these errors were encountered: