Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopters page: some links have empty link text #5643

Closed
chalin opened this issue Nov 20, 2024 · 3 comments · Fixed by #5662
Closed

Adopters page: some links have empty link text #5643

chalin opened this issue Nov 20, 2024 · 3 comments · Fixed by #5662
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@chalin
Copy link
Contributor

chalin commented Nov 20, 2024

See https://opentelemetry.io/ecosystem/adopters/, e.g.:

image

Note that the "Learn more" link text for Bureau.id is empty. By chance we're generating an external link icon, otherwise, the link wouldn't appear at all.
@chalin chalin added the bug Something isn't working label Nov 20, 2024
@svrnm
Copy link
Member

svrnm commented Nov 20, 2024

They miss a referenceTitle in https://github.com/open-telemetry/opentelemetry.io/blob/main/data/ecosystem/adopters.yaml

@svrnm svrnm added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 20, 2024
@Yuvraj-Achrekar
Copy link
Contributor

Can i attempt this ?

@svrnm
Copy link
Member

svrnm commented Nov 21, 2024

Can i attempt this ?

sure!

@Yuvraj-Achrekar Yuvraj-Achrekar mentioned this issue Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update adopters.yaml for Adoptors page Yuvraj-Achrekar/opentelemetry.io
3 participants
@svrnm @chalin @Yuvraj-Achrekar