Change TargetAllocator configmap for ScrapeConfig and Probe CR

[dominicqi]

Description: Enable ScrapeConfigSelector and ProbeSelector support in OpenTelemetryTargetAllocatorPrometheusCR, create right configmap for target allocator

Link to tracking Issue(s):

• Resolves: [target allocator] Support the Probe and ScrapeConfig Prometheus Operator CRDs #1842

Testing: add test in configmap_test.go

Documentation: ScrapeConfigSelector and ProbeSelector config in v1beta1 api doc

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: dominicqi / name: qiyang (ba014bc, 19720d8, d87da69, bcf25f0, 51f12aa)

[swiatekm]

Looks good overall, some relatively minor nitpicks aside. Could you also add an e2e test for this behaviour? You can probably modify https://github.com/open-telemetry/opentelemetry-operator/tree/main/tests/e2e-targetallocator/targetallocator-prometheuscr.

[dominicqi]

Looks good overall, some relatively minor nitpicks aside. Could you also add an e2e test for this behaviour? You can probably modify https://github.com/open-telemetry/opentelemetry-operator/tree/main/tests/e2e-targetallocator/targetallocator-prometheuscr.

I'm not very familiar with E2E testing yet. I will take some time to look into it.

[dominicqi]

@swiatekm e2e test added

[swiatekm]

@swiatekm e2e test added

Thanks for adding it! What you've added checks that setting the attribute on the CR leads to a change in the target allocator ConfgMap, which is a part of it. But since this PR effectively exposes this functionality to users, I'd like the new e2e test to also check that we actually allocate targets derived from ScrapeConfigs and Probes.

What I'd like you to add is the following:

• Create a ScrapeConfig and/or Probe targetting the Otel collector you create in the test
• Set the selector to select that ScrapeConfig/Probe
• Use Jobs similar to the existing test to verify that the target allocator is actually allocating targets generated for the ScrapeConfig/Probe

Does that make sense?

For the record, the rest of your PR looks good to me.

[jaronoff97]

@dominicqi thanks for adding this :D I was planning on doing this when I got back from PTO but glad to see this is already here 🥳 With the changes that Mikolaj mentioned above this should be g2g.