-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingress #3441
base: main
Are you sure you want to change the base?
Ingress #3441
Conversation
It's a POC and work is still in progress. Once the code for extension service is merged, this branch will be re-based. |
ObjectMeta: metav1.ObjectMeta{ | ||
Name: name, | ||
Namespace: params.OtelCol.Namespace, | ||
Annotations: params.OtelCol.Spec.Ingress.Annotations, // can the spec annotations be used? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just wondering if we can use the OtelCol.ObjectMeta.Annotations
instead of Ingress.Annotations
as this function will be responsible for creating ingress for extension services.
Signed-off-by: Ankit152 <[email protected]>
Signed-off-by: Ankit152 <[email protected]>
Signed-off-by: Ankit152 <[email protected]>
Signed-off-by: Ankit152 <[email protected]>
Signed-off-by: Ankit152 <[email protected]>
Signed-off-by: Ankit152 <[email protected]>
Description:
Link to tracking Issue(s):
Testing:
Documentation: