Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix envtest version when latest need golang 1.23 #3360

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix envtest version when latest need golang 1.23 #3360

wants to merge 2 commits into from

Conversation

huanghuangzym
Copy link

@huanghuangzym huanghuangzym commented Oct 17, 2024 •
edited by pavolloffay
Loading

Description:

Link to tracking Issue(s):

Testing:

Documentation:

@huanghuangzym huanghuangzym requested a review from a team as a code owner October 17, 2024 07:29
pavolloffay
pavolloffay reviewed Oct 17, 2024
View reviewed changes
Makefile
@@ -67,6 +67,8 @@ OPERATOR_SDK_VERSION ?= 1.29.0

CERTMANAGER_VERSION ?= 1.10.0

ENVTEST_VERSION ?= release-0.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use 0.19?

https://github.com/kubernetes-sigs/controller-runtime/releases

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
it seems can not
https://github.com/kubernetes-sigs/controller-runtime/tree/main/tools/setup-envtest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we pin this to https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.5 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release-0.18 maybe 0.18 latest? should we need 0.18 latest?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're pinning it, I'd prefer a specific tag rather than a branch,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok , i got it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go: downloading sigs.k8s.io/controller-runtime v0.18.5
go: sigs.k8s.io/controller-runtime/tools/[email protected]: module sigs.k8s.io/[email protected] found, but does not contain package sigs.k8s.io/controller-runtime/tools/setup-envtest
it seems can not use specific tag

@pavolloffay pavolloffay added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 17, 2024
@pavolloffay
Copy link
Member

I have restarted tests and still failed. It seems there are some issues

PASS
ok  	github.com/open-telemetry/opentelemetry-operator/pkg/featuregate	1.014s
failed to start testEnv: unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH
FAIL	github.com/open-telemetry/opentelemetry-operator/pkg/instrumentation	0.067s
failed to start testEnv: unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH
FAIL	github.com/open-telemetry/opentelemetry-operator/pkg/instrumentation/upgrade	0.091s
?   	github.com/open-telemetry/opentelemetry-operator/tests/test-e2e-apps/golang	[no test files]

@pavolloffay
Copy link
Member

The tests are still failing

ok  	github.com/open-telemetry/opentelemetry-operator/pkg/featuregate	1.018s
failed to start testEnv: unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH
FAIL	github.com/open-telemetry/opentelemetry-operator/pkg/instrumentation	0.088s
failed to start testEnv: unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH
FAIL	github.com/open-telemetry/opentelemetry-operator/pkg/instrumentation/upgrade	0.068s
?   	github.com/open-telemetry/opentelemetry-operator/tests/test-e2e-apps/golang	[no test files]
=== RUN   TestEffectiveAnnotationValue

@huanghuangzym
Copy link
Author

The tests are still failing

ok  	github.com/open-telemetry/opentelemetry-operator/pkg/featuregate	1.018s
failed to start testEnv: unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH
FAIL	github.com/open-telemetry/opentelemetry-operator/pkg/instrumentation	0.088s
failed to start testEnv: unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH
FAIL	github.com/open-telemetry/opentelemetry-operator/pkg/instrumentation/upgrade	0.068s
?   	github.com/open-telemetry/opentelemetry-operator/tests/test-e2e-apps/golang	[no test files]
=== RUN   TestEffectiveAnnotationValue

let me see see

swiatekm
swiatekm reviewed Oct 21, 2024
View reviewed changes
Makefile
@@ -498,7 +500,7 @@ $(CONTROLLER_GEN): $(LOCALBIN)
.PHONY: envtest
envtest: $(ENVTEST) ## Download envtest-setup locally if necessary.
$(ENVTEST): $(LOCALBIN)
@test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
@test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@$(ENVTEST_VERSION)
Copy link
Contributor

@swiatekm swiatekm Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some weirdness going on here with the installation in the CI. @huanghuangzym can you try using our install macro instead:

Suggested change
@test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@$(ENVTEST_VERSION)
$(call go-get-tool,$(ENVTEST), sigs.k8s.io/controller-runtime/tools/setup-envtest,$(ENVTEST_VERSION))

@swiatekm swiatekm mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm left review comments

@pavolloffay pavolloffay pavolloffay approved these changes

@frzifus frzifus frzifus approved these changes

@iblancasa iblancasa iblancasa approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can not excte test as latest envtest need golang 1.23
5 participants
@huanghuangzym @pavolloffay @iblancasa @frzifus @swiatekm