Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[target allocator] Support the Probe and ScrapeConfig Prometheus Operator CRDs #1842

Closed
matej-g opened this issue Jun 15, 2023 · 1 comment · Fixed by #3394 · May be fixed by #3469
Closed

[target allocator] Support the Probe and ScrapeConfig Prometheus Operator CRDs #1842

matej-g opened this issue Jun 15, 2023 · 1 comment · Fixed by #3394 · May be fixed by #3469
Assignees
@yuriolisa
Labels
area:target-allocator Issues for target-allocator

Comments

@matej-g
Copy link
Contributor

matej-g commented Jun 15, 2023

Off the back of the suggestion in #1710 (comment)

In the Prometheus Operator CRDs, there are couple more CRDs that it would be nice to support:

Actions to take:

  • Evaluate if we want to support both
  • Implement
@pavolloffay pavolloffay added the area:target-allocator Issues for target-allocator label Jun 15, 2023
@yuriolisa yuriolisa self-assigned this May 6, 2024
@jaronoff97
Copy link
Contributor

I'm definitely in support of this, it also should be much easier to do now that we use the upstream prom-operator methods. @yuriolisa was interested in testing this out.

@yuriolisa yuriolisa mentioned this issue Jul 4, 2024
Closed
@jaronoff97 jaronoff97 mentioned this issue Oct 25, 2024
Merged
@dominicqi dominicqi mentioned this issue Nov 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriolisa yuriolisa

Labels
area:target-allocator Issues for target-allocator
Projects
None yet
Milestone
No milestone
4 participants
@pavolloffay @jaronoff97 @matej-g @yuriolisa