-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move validation to be part of the CRD #3319
Comments
Hi @jaronoff97 I am an Outreachy applicant, and I would like to work on this issue. I'll review the project and keep you updated on my progress. In the meantime, I would appreciate any insights or guidance you could provide to help me address this issue. |
@mercybassey sounds good! one issue with this is that feature went beta in Kubernetes 1.25 and stable in kubernetes 1.29 (link) and right now our minimum supported version is 1.23. We will probably need to bump that minimum version as part of this. We have an open issue here for that #2798 |
@jaronoff97 Thank you for the update! I’d like to clarify if I can go ahead with migrating the validation rules to the CRDs while keeping an eye on the progress of issue #2798 regarding the version bump. |
Assuming the @mercybassey if you want to work on this, I'd limit the scope to just adding the existing webhook validations as validation rules, without removing the former. You can start by familiarizing yourself with the webhook logic, how we define and annotate our CRDs using kubebuilder, and kubebuilder's own documentation. What you want for CRD validation rules is the Here's also a tutorial showing how to use CEL with kubebuilder in practice. |
Thank you for your guidance. I'll start working on it right away. |
Component(s)
collector, auto-instrumentation, target allocator, opamp
Is your feature request related to a problem? Please describe.
CRDs can have validation rules now, it would be great to move our existing webhooks (for whatever we can) into these.
Describe the solution you'd like
Migrate to the kubebuilder's support for CRD validation rules. This would probably require us to bump our min supported version ...
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: