Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make otelhttp produce old, new and duplicate Server Trace Attributes #5331

Closed
4 tasks done
MadVikingGod opened this issue Mar 28, 2024 · 3 comments · May be fixed by #5092
Closed
4 tasks done

Make otelhttp produce old, new and duplicate Server Trace Attributes #5331

MadVikingGod opened this issue Mar 28, 2024 · 3 comments · May be fixed by #5092
Assignees
@MadVikingGod @VinozzZ
Labels
area: instrumentation Related to an instrumentation package instrumentation: otelhttp

Comments

@MadVikingGod
Copy link
Contributor

MadVikingGod commented Mar 28, 2024 •
edited by MrAlias
Loading

Make instrumentation/net/http/otelhttp produce Server Traces following the migration plan #5132.

A user should be able to produce Traces from the handler in current semconv (default), the latest semconv (1.24.0), and a duplicate form based on the Environment variable OTEL_HTTP_CLIENT_COMPATIBILITY_MODE
@MadVikingGod MadVikingGod converted this from a draft issue Mar 28, 2024
@MadVikingGod MadVikingGod linked a pull request Mar 28, 2024 that will close this issue
Add semconv v1.24.0 to otelhttp #5092
Open
@MadVikingGod MadVikingGod added area: instrumentation Related to an instrumentation package instrumentation: otelhttp labels Mar 28, 2024
@MadVikingGod MadVikingGod mentioned this issue Mar 29, 2024
Merged
This was referenced Apr 17, 2024
Closed
Merged
Closed
@dashpole dashpole mentioned this issue May 8, 2024
Open
MadVikingGod added a commit that referenced this issue Jun 14, 2024
@MadVikingGod
HTTP Semconv migration Part3 Server - v1.24.0 support (#5401)
58935bd 
This change adds the new semantic version (v1.24.0) attribute producer
to the semconv of otlehttp.

The full PR is
#5092
Part of
#5331

---------

Co-authored-by: Aaron Clawson <[email protected]>
@MrAlias MrAlias moved this from In Progress to Todo in Go: HTTP Semconv Migration Jun 20, 2024
@MrAlias
Copy link
Contributor

MrAlias commented Jul 11, 2024

For changelog entry: New environment variable that will produce both old and new needs to be added to the changelog.

@VinozzZ
Copy link
Contributor

VinozzZ commented Jul 11, 2024

I will work on adding the changelog entry

@VinozzZ VinozzZ mentioned this issue Jul 12, 2024
Merged
dmathieu added a commit that referenced this issue Jul 16, 2024
@VinozzZ @dmathieu
Update CHANGELOG.md for OTEL_HTTP_CLIENT_COMPATIBILITY_MODE environme…
22bae49 
…nt variable (#5908)

Add a changelog entry for the new `OTEL_HTTP_CLIENT_COMPATIBILITY_MODE`
environment variable introduced in #5331

---------

Co-authored-by: Damien Mathieu <[email protected]>
@MrAlias
Copy link
Contributor

MrAlias commented Jul 18, 2024

Done

@MrAlias MrAlias closed this as completed Jul 18, 2024
luca-filipponi pushed a commit to luca-filipponi/opentelemetry-go-contrib that referenced this issue Aug 9, 2024
@VinozzZ @dmathieu @luca-filipponi
Update CHANGELOG.md for OTEL_HTTP_CLIENT_COMPATIBILITY_MODE environme…
6b1637a 
…nt variable (open-telemetry#5908)

Add a changelog entry for the new `OTEL_HTTP_CLIENT_COMPATIBILITY_MODE`
environment variable introduced in open-telemetry#5331

---------

Co-authored-by: Damien Mathieu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadVikingGod MadVikingGod

@VinozzZ VinozzZ

Labels
area: instrumentation Related to an instrumentation package instrumentation: otelhttp
Projects
Go: HTTP Semconv Migration
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add semconv v1.24.0 to otelhttp MadVikingGod/opentelemetry-go-contrib
3 participants
@MadVikingGod @MrAlias @VinozzZ