Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: Investigate using metrics key with bucket index for histograms #702

Open
tsloughter opened this issue Feb 29, 2024 · 0 comments
Open

Comments

@tsloughter
Copy link
Member

Instead of bucket_counts being a counters array which will be able to get out of sync with the min/max values stored separate in the ets element we should see about changing the ets table for histograms to use a key of {Key, BucketIdx}.

Then either a separate element with the min/max is kept or could even keep min/max per-bucket and aggregate them during collection I think. That way only a single element has to be updated when a bucket is incremented.

I don't think this has to be implemented before we cut GA of metrics, but it should be investigated to make sure it is possible with the current design and won't change too much post-GA to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant