Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry.Instrumentation.Http: avoid duplicate addition of tags and potential conflicting logic on .NET 9+ #2156

Closed
antonfirsov opened this issue Oct 3, 2024 · 1 comment
Labels
comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http enhancement New feature or request

Comments

@antonfirsov
Copy link

Component

OpenTelemetry.Instrumentation.Http

Is your feature request related to a problem?

.NET 9 emits standard tags natively, see dotnet/runtime#104251

I didn't have a chance to check how would OpenTelemetry.Instrumentation.Http behave on .NET 9, but I think it would be important to test it and remove duplicate (and potential conflicting) logic from HttpHandlerDiagnosticsListener on .NET 9+.

Note that there are no native enrichment and filtering capabilities yet, users would still need to rely on OpenTelemetry.Instrumentation.Http or on workarounds for that.

What is the expected behavior?

N/A

Which alternative solutions or features have you considered?

N/A

Additional context

N/A

@antonfirsov antonfirsov added the enhancement New feature or request label Oct 3, 2024
@github-actions github-actions bot added the comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http label Oct 3, 2024
@TimothyMothra
Copy link
Contributor

I'm closing this as a duplicate of #2029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants