Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http method tag for activity creation #57287

Open
1 task done
roycald245 opened this issue Aug 12, 2024 · 0 comments · May be fixed by open-telemetry/opentelemetry-dotnet-contrib#2023
Open
1 task done

Add http method tag for activity creation #57287

roycald245 opened this issue Aug 12, 2024 · 0 comments · May be fixed by open-telemetry/opentelemetry-dotnet-contrib#2023
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Comments

@roycald245
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Like #50488. Additional information from the http request is needed in the sampler to determine whether to sample or not. Specifically, http method.

Describe the solution you'd like

Like #33458. Adding the additional tag alongside the url seems the trivial solution.

Additional context

No response
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Aug 12, 2024
@amcasey amcasey added api-suggestion Early API idea and discussion, it is NOT ready for implementation area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Aug 12, 2024
@roycald245 roycald245 linked a pull request Aug 26, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Instrumentation.AspNet] pass http.request.method to sampler roycald245/opentelemetry-dotnet-contrib
2 participants
@amcasey @roycald245