-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add section for key metrics guide #412
feat: add section for key metrics guide #412
Conversation
✅ Deploy Preview for saucedocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great, Fatuma. There are a couple of comments in the review.
We might want to add YOLO Coders as well. Here's more info on that: https://opensauced.pizza/blog/yolo-coder.
Thank you. I've made the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's almost there! Reading through it again, I think it makes more sense to use the third person instead of second person. We also want to make sure that the sections are written for a general audience (including teams, maintainers, and contributors) and not just contributors.
Makes sense! Done 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for all your work on this, Fatuma!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @FatumaA! ✨
Description
This PR adds a key metrics guide section to the documentation.
Related Tickets & Documents
Fixes #407
Mobile & Desktop Screenshots/Recordings
N/A
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?