Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evaluation details to finally hook stage #403

Open
toddbaert opened this issue Dec 11, 2024 · 0 comments
Open

Add evaluation details to finally hook stage #403

toddbaert opened this issue Dec 11, 2024 · 0 comments

Comments

@toddbaert
Copy link
Member

Add evaluation details to finally hook stage.

Notes

This breaks the signature of the finally stages based on this spec enhancement. It is not considered a breaking change to the SDK because hooks are marked as experimental in the spec, and the change has no impact on known hooks.

- finally(hookContext, hookHints)
+finally(hookContext, evaluationDetails, hookHints)

Acceptance criteria:

  • finally hook stage modified
  • associated tests

Follow ups:

  • update contribs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant