We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The implementation is not fulfilling the abstraction definition: https://github.com/open-feature/php-sdk/blob/4e25be68937dc4ec405366cb6ba726f66fc0e5c8/src/implementation/provider/AbstractProvider.php#L19
protected static string $NAME = 'AbstractProvider';
The implementation is pointing not to a property but to a constant.
protected const NAME = 'SplitProvider';
This is leading to getMetadata method in the implementation to return all the time "AbstractProvider" value
getMetadata method to return the proper provider
getMetadata
provider
<?php abstract class AbstractProvider { protected static string $NAME = 'AbstractProvider'; public function getMetadata() { return static::$NAME; } } class SplitProvider extends AbstractProvider { protected const NAME = 'SplitProvider'; } class FlagdProvider extends AbstractProvider { protected const NAME = 'FlagdProvider'; } $splitProvider = new SplitProvider(); var_dump($splitProvider->getMetadata()); $flagDProvider = new FlagdProvider(); var_dump($flagDProvider->getMetadata()); ?>
The text was updated successfully, but these errors were encountered:
#105 Could somebody please check this MR 🙏
Sorry, something went wrong.
No branches or pull requests
Observed behavior
The implementation is not fulfilling the abstraction definition:
https://github.com/open-feature/php-sdk/blob/4e25be68937dc4ec405366cb6ba726f66fc0e5c8/src/implementation/provider/AbstractProvider.php#L19
The implementation is pointing not to a property but to a constant.
This is leading to getMetadata method in the implementation to return all the time "AbstractProvider" value
Expected Behavior
getMetadata
method to return the properprovider
Steps to reproduce
The text was updated successfully, but these errors were encountered: