Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace test-harness submodule with spec submodule #743

Open
toddbaert opened this issue Jan 5, 2024 · 0 comments
Open

Replace test-harness submodule with spec submodule #743

toddbaert opened this issue Jan 5, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

toddbaert commented Jan 5, 2024 •
edited
Loading

The evaluation.feature gherkin file is currently being supplied from the test-harness module. In our efforts to remove all flagd-related dependencies from the SDKs, this gherkin is now available in the spec (with a few minor changes).

Delete the test-harness submodule and replace it with a submodule for the spec, and update the scripts in the package.json to get the evaluation.feature from that new location. You may need to make a few minor changes to the test implementation to match minor language changes in the gherkin.
@toddbaert toddbaert mentioned this issue Jan 5, 2024
Merged
@beeme1mr beeme1mr added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beeme1mr @toddbaert