feat: export use-open-feature-client-status with suspense support #1082
Conversation
wichopy
force-pushed
the
issue-1036
branch
2 times, most recently
from
8172213 to
f1ff607
Compare
wichopy
changed the title
| * @returns {ProviderStatus} status of the client for this scope | ||
| */ | ||
| export function useOpenFeatureClientStatus(): ProviderStatus { | ||
| export function useOpenFeatureClientStatus(options?: Options) { |
There was a problem hiding this comment.
the great debate of return types 😅
| const defaultedOptions = { ...DEFAULT_OPTIONS, ...useProviderOptions(), ...normalizeOptions(options) }; | ||
|
|
||
| if (defaultedOptions.suspendUntilReady && status === ProviderStatus.NOT_READY) { | ||
| suspendUntilReady(client); |
There was a problem hiding this comment.
Some of the code here is identical to the useWhenProviderReady hook - we might want to commonize it into a util.
| * @returns {ProviderStatus} status of the client for this scope | ||
| */ | ||
| export function useOpenFeatureClientStatus(): ProviderStatus { | ||
| export function useOpenFeatureClientStatus(options?: Options) { |
There was a problem hiding this comment.
We call this hook internally from useWhenProviderReady; we should probably explicitly disable suspense in the call from that hook so we don't suspend when we don't want to (since that hook also has it's own suspense logic).
|
@wichopy Sorry for the delay - KubeCon really slowed things down for us, still playing some catch-up! I still think this is valuable, and I think you're on the right track. I left some thoughts. We also need some tests (probably very similar to the other tests involving hooks and suspense). |
toddbaert
requested review from
beeme1mr,
aepfli,
toddbaert,
tjosepo,
lukas-reining and
guidobrei
Signed-off-by: William Chou <[email protected]> Signed-off-by: Will Chou <[email protected]>
Signed-off-by: William Chou <[email protected]> Signed-off-by: Will Chou <[email protected]>
Signed-off-by: Will Chou <[email protected]>
Signed-off-by: Will Chou <[email protected]>
Signed-off-by: Will Chou <[email protected]>
Signed-off-by: Will Chou <[email protected]>
This PR
exposes the internal open feature client status hook so developers can act on non-ready resolved states
Related Issues
Fixes #1036
Notes
Follow-up Tasks
How to test