Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement Logging Hook #284

Closed
toddbaert opened this issue Sep 4, 2024 · 2 comments · Fixed by #289
Closed

[FEATURE] Implement Logging Hook #284

toddbaert opened this issue Sep 4, 2024 · 2 comments · Fixed by #289
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

toddbaert commented Sep 4, 2024

Requirements

Java implementation: open-feature/java-sdk#1084

@toddbaert toddbaert added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 4, 2024
@liran2000
Copy link
Member

hi @toddbaert @Kavindu-Dodan,
I am looking at this issue,
I think it can be implemented via slog from standard GO library, but as it started since GO 1.21 and go-sdk is still at GO 1.20, PR can be prepared, and can be merged later when go-sdk move to GO 1.21.
what do you think ? and when go-sdk planned to move to GO 1.21 ?

@Kavindu-Dodan
Copy link
Contributor

@liran2000 the SDK should already be on Go 1.22 as latest supported versions are 1.22 & 1.23. So I don't think this is a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants