Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flagd RPC and OFREP to support metadata #1464

Open
Tracked by #1440
toddbaert opened this issue Dec 11, 2024 · 3 comments · May be fixed by #1476
Open
Tracked by #1440

Update flagd RPC and OFREP to support metadata #1464

toddbaert opened this issue Dec 11, 2024 · 3 comments · May be fixed by #1476
Assignees
Labels
good first issue Good for newcomers

Comments

@toddbaert
Copy link
Member

toddbaert commented Dec 11, 2024

With this schema change, flag metadata can now be stored in flag configuration files. Specifically, these can contain things like version and flag set id information so that consumers can use this data in flag evaluations, caching, telemetry etc.

We need to add this metadata into flags which are evaluated in RPC mode as well as in OFREP. That means modifications to the handlers here and here, respectively. Essentially, we need to take the properties from the flag definition and include them in the response in the flag metadata field.

Acceptance criteria:

@toddbaert toddbaert added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 11, 2024
@aasifkhan7
Copy link

I'd like to work on this one @toddbaert ! Could you please assign it to me?

@aepfli
Copy link
Member

aepfli commented Dec 16, 2024

i assigned you @aasifkhan7, if you need help, feel free to reach out to us.

@beeme1mr beeme1mr removed the help wanted Extra attention is needed label Dec 16, 2024
@aasifkhan7
Copy link

This is the initial draft of the PR: #1476.

@aepfli @toddbaert @beeme1mr Could you please take a look and let me know if I'm on the right track, or if I'm off course? I'll continue refining the PR in subsequent iterations.

@aasifkhan7 aasifkhan7 linked a pull request Dec 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants