Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring token icons to the SDK from app #87

Open
pi0neerpat opened this issue Jul 23, 2024 · 0 comments
Open

Bring token icons to the SDK from app #87

pi0neerpat opened this issue Jul 23, 2024 · 0 comments
Assignees
Labels

Comments

@pi0neerpat
Copy link
Member

pi0neerpat commented Jul 23, 2024

The app currently imports tokens from src/utils/tokens.ts
However they should be imported from the SDK, so we only need to make updates there for new collateral types.

Two patterns we could follow:

  1. token icons are included as an entry for each token in the the token list object
  2. OR, token icons are exported from a particular file

I prefer option 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants