-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use klog for logging
#166
Open
dhaiducek
wants to merge
2
commits into
open-cluster-management-io:main
Choose a base branch
from
dhaiducek:klog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use klog for logging
#166
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ require ( | |
| github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.74.0 | ||
| github.com/spf13/cobra v1.8.0 | ||
| github.com/spf13/pflag v1.0.5 | ||
| github.com/stolostron/kubernetes-dependency-watches v0.7.0 | ||
| github.com/stolostron/kubernetes-dependency-watches v0.8.1 | ||
| k8s.io/apimachinery v0.29.5 | ||
| k8s.io/client-go v0.29.5 | ||
| k8s.io/component-base v0.29.5 | ||
|
|
@@ -20,19 +20,13 @@ require ( | |
| sigs.k8s.io/controller-runtime v0.17.5 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/antlr/antlr4/runtime/Go/antlr/v4 v4.0.0-20230305170008-8188dc5388df // indirect | ||
| github.com/felixge/fgprof v0.9.3 // indirect | ||
| github.com/go-task/slim-sprig/v3 v3.0.0 // indirect | ||
| github.com/matttproud/golang_protobuf_extensions/v2 v2.0.0 // indirect | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/BurntSushi/toml v1.4.0 // indirect | ||
| github.com/Masterminds/goutils v1.1.1 // indirect | ||
| github.com/Masterminds/semver/v3 v3.2.1 // indirect | ||
| github.com/Masterminds/sprig/v3 v3.2.3 // indirect | ||
| github.com/NYTimes/gziphandler v1.1.1 // indirect | ||
| github.com/antlr/antlr4/runtime/Go/antlr/v4 v4.0.0-20230305170008-8188dc5388df // indirect | ||
| github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2 // indirect | ||
| github.com/beorn7/perks v1.0.1 // indirect | ||
| github.com/cenkalti/backoff/v4 v4.3.0 // indirect | ||
|
|
@@ -45,6 +39,7 @@ require ( | |
| github.com/evanphx/json-patch v5.9.0+incompatible // indirect | ||
| github.com/evanphx/json-patch/v5 v5.9.0 // indirect | ||
| github.com/fatih/structs v1.1.0 // indirect | ||
| github.com/felixge/fgprof v0.9.3 // indirect | ||
| github.com/felixge/httpsnoop v1.0.4 // indirect | ||
| github.com/fsnotify/fsnotify v1.7.0 // indirect | ||
| github.com/ghodss/yaml v1.0.0 // indirect | ||
|
|
@@ -53,20 +48,21 @@ require ( | |
| github.com/go-openapi/jsonpointer v0.21.0 // indirect | ||
| github.com/go-openapi/jsonreference v0.21.0 // indirect | ||
| github.com/go-openapi/swag v0.23.0 // indirect | ||
| github.com/go-task/slim-sprig/v3 v3.0.0 // indirect | ||
| github.com/gobwas/glob v0.2.3 // indirect | ||
| github.com/gogo/protobuf v1.3.2 // indirect | ||
| github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect | ||
| github.com/golang/protobuf v1.5.4 // indirect | ||
| github.com/google/cel-go v0.17.8 // indirect | ||
| github.com/google/gnostic-models v0.6.8 // indirect | ||
| github.com/google/gnostic-models v0.6.9-0.20230804172637-c7be7c783f49 // indirect | ||
| github.com/google/go-cmp v0.6.0 // indirect | ||
| github.com/google/gofuzz v1.2.0 // indirect | ||
| github.com/google/pprof v0.0.0-20240528025155-186aa0362fba // indirect | ||
| github.com/google/uuid v1.6.0 // indirect | ||
| github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 // indirect | ||
| github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0 // indirect | ||
| github.com/huandu/xstrings v1.4.0 // indirect | ||
| github.com/imdario/mergo v1.0.0 // indirect | ||
| github.com/imdario/mergo v0.3.16 // indirect | ||
| github.com/inconshreveable/mousetrap v1.1.0 // indirect | ||
| github.com/josharian/intern v1.0.0 // indirect | ||
| github.com/json-iterator/go v1.1.12 // indirect | ||
|
|
@@ -80,9 +76,9 @@ require ( | |
| github.com/openshift/client-go v0.0.0-20231218140158-47f6d749b9d9 // indirect | ||
| github.com/pkg/errors v0.9.1 // indirect | ||
| github.com/pkg/profile v1.7.0 // indirect | ||
| github.com/prometheus/client_golang v1.18.0 // indirect | ||
| github.com/prometheus/client_golang v1.19.1 // indirect | ||
| github.com/prometheus/client_model v0.6.1 // indirect | ||
| github.com/prometheus/common v0.45.0 // indirect | ||
| github.com/prometheus/common v0.53.0 // indirect | ||
| github.com/prometheus/procfs v0.15.0 // indirect | ||
| github.com/shopspring/decimal v1.4.0 // indirect | ||
| github.com/sirupsen/logrus v1.9.3 // indirect | ||
|
|
@@ -129,7 +125,7 @@ require ( | |
| k8s.io/api v0.29.5 // indirect | ||
| k8s.io/apiextensions-apiserver v0.29.5 // indirect | ||
| k8s.io/apiserver v0.29.5 // indirect | ||
| k8s.io/klog v1.0.0 // indirect | ||
| k8s.io/klog v1.0.0 | ||
| k8s.io/kms v0.29.5 // indirect | ||
| k8s.io/kube-aggregator v0.29.5 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20240521193020-835d969ad83a // indirect | ||
|
|
@@ -142,4 +138,9 @@ require ( | |
| sigs.k8s.io/yaml v1.4.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/imdario/mergo => github.com/imdario/mergo v0.3.16 // Replaced so that 'go get -u' works. Remove/bump when upgrading. | ||
| replace ( | ||
| // Replaced for compatibility with k8s.io/[email protected] | ||
| // Above v0.29.5, we'd need to upgrade Go to v1.22, which isn't compatible | ||
| github.com/prometheus/client_golang => github.com/prometheus/client_golang v1.18.0 | ||
| github.com/prometheus/common => github.com/prometheus/common v0.47.0 | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trades out replace statements, but I'm assuming the
kubernetes-dependency-watchversion bump is desireable, so hopefully the next round we can get rid of these entirely.