Use klog for logging
#166
Use klog for logging
#166
Conversation
There are probably better options, but this works for now (it logs the filename without a path). Signed-off-by: Dale Haiducek <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Dale Haiducek <[email protected]>
| replace ( | ||
| // Replaced for compatibility with k8s.io/[email protected] | ||
| // Above v0.29.5, we'd need to upgrade Go to v1.22, which isn't compatible | ||
| github.com/prometheus/client_golang => github.com/prometheus/client_golang v1.18.0 | ||
| github.com/prometheus/common => github.com/prometheus/common v0.47.0 | ||
| ) |
There was a problem hiding this comment.
Trades out replace statements, but I'm assuming the kubernetes-dependency-watch version bump is desireable, so hopefully the next round we can get rid of these entirely.
|
@dhaiducek what was the reason for moving to klog? |
There were other logging statements using Of course, I could try to implement the same logging flows as our other controllers. I'm not actually sure why that hadn't been done previously though... |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There are probably better options, but this works for now (it logs the filename without a path).
Also cleans up
go.mod.