Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donate Button: Open new tab #82

Open
attali-david opened this issue Jun 25, 2023 · 2 comments
Open

Donate Button: Open new tab #82

attali-david opened this issue Jun 25, 2023 · 2 comments
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@attali-david
Copy link
Collaborator

The donate button currently redirects user to our donate page. It should open a new tab with our donate page instead.

@attali-david attali-david added good first issue Good for newcomers v2 v2 work to do before v3 labels Jun 25, 2023
@teeshaa
Copy link

teeshaa commented Jun 26, 2023

Please assign me this issue I would like to contribute.

@lianilychee lianilychee added this to the V2.1 milestone Jun 27, 2023
@lianilychee lianilychee removed the v2 v2 work to do before v3 label Jun 27, 2023
@tjdev7 tjdev7 self-assigned this Aug 3, 2023
@tjdev7 tjdev7 moved this to In Progress in Website refresh Aug 3, 2023
@djneill
Copy link

djneill commented Oct 29, 2023

Submitted pull request #101 so the donate button will open in a new window.

The link component from next/link is designed for client-side navigation within the Next.js application. It's not meant for external links and doesn't support the target attribute '_blank'

Changed the link element to an anchor tag. The donate button is now opening in a new window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
Status: In Progress
Development

No branches or pull requests

5 participants