Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fire effect #41

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

RustoMCSpit
Copy link
Contributor

@RustoMCSpit RustoMCSpit commented Dec 5, 2024

I can't provide audio as it's only on Mac.

Files aren't returning correct:

X jerryuhoo/fire | 1.0.1 | downloads/jerryuhoo/fire/1.0.1/Apple.M.series.zip-plugins.zip
- sha256 (Required) received '9a05a7553193f65c6d859e7176c17365a80f05e32b5a433942bbab2333264cac' expected '0019dfc4b32d63c1392aa264aed2253c1e0c2fb09216f8e2cc269bbfb8bb49b5'
- size (Required) received '2777808' expected '9'

@kmturley
Copy link
Member

kmturley commented Dec 6, 2024

If a plugin only supports one platform I don't think we should add yet.
It would be better to push the plugin owner to do cross-platform builds and then include it.

@RustoMCSpit
Copy link
Contributor Author

If a plugin only supports one platform I don't think we should add yet. It would be better to push the plugin owner to do cross-platform builds and then include it.

i dont see a problem? many plugins only support windows. good to just put it on the registry.

also theres presumably an error with how your code reads mac files. i provided an error output above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants