Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: New flag to pass in custom unique UUID #163

Closed
5 tasks done
bwendlandt-intel opened this issue Jul 24, 2023 · 3 comments · Fixed by #237
Closed
5 tasks done

Feature Request: New flag to pass in custom unique UUID #163

bwendlandt-intel opened this issue Jul 24, 2023 · 3 comments · Fixed by #237
Assignees
Labels
enhancement New feature or request released

Comments

@bwendlandt-intel
Copy link
Contributor

bwendlandt-intel commented Jul 24, 2023

Currently, some AMT devices could have duplicate UUIDs due to OEM errors. This causes one device to overwrite the other within the database and secret store leading to issues when managing devices since the UUID is the sole primary key right now.

It would be good to have a new flag, like-id, when running RPC-Go that will allow the passing of a custom id string in place of using the UUID. This would allow the ability to solve the duplication problem remotely by sidestepping UUID rather than having to use manual touch OEM solutions to fix the UUIDs themselves.

This would not work for CIRA-based connected devices. Exclusively solves the problem for enterprise, non-CIRA type environments.

Tasks:

  • Add -uuid input flag to RPC-Go
  • uuid provided must match standard uuid format
  • RPC-Go replaces AMT uuid when sending device data to RPS
  • Add warning message to RPC-Go that using -uuid flag to override AMT uuid will prevent AMT device from connecting to MPS
  • Add documentation to RPC-Go page for the -uuid flag and the impact of using this feature. Also document new error code
@bwendlandt-intel bwendlandt-intel added the enhancement New feature or request label Jul 24, 2023
@bwendlandt-intel bwendlandt-intel moved this from 🆕 New to 📋 Backlog in Feature Backlog Jul 24, 2023
@matt-primrose
Copy link
Contributor

  • Update the database script to make a composite key of UUID and Friendly name
  • Add a device using the REST API
  • Discuss the observations with team and finalize the next steps

@matt-primrose matt-primrose moved this to Backlog in Sprint Planning Aug 25, 2023
@matt-primrose matt-primrose moved this from Backlog to Todo in Sprint Planning Aug 25, 2023
@mechris1 mechris1 moved this from Todo to Done in Sprint Planning Sep 8, 2023
@matt-primrose matt-primrose moved this from Done to Todo in Sprint Planning Sep 12, 2023
@matt-primrose
Copy link
Contributor

Previous implementation proposal won't work. Updated original post with updated tasks for implementation

@matt-primrose matt-primrose moved this from Todo to Backlog in Sprint Planning Sep 12, 2023
@matt-primrose matt-primrose moved this from Backlog to Todo in Sprint Planning Sep 12, 2023
@matt-primrose matt-primrose added this to the September 2023 Release milestone Sep 12, 2023
@Craig-Spencer-12 Craig-Spencer-12 self-assigned this Sep 13, 2023
@Craig-Spencer-12 Craig-Spencer-12 moved this from 📋 Backlog to 🏗 In progress in Feature Backlog Sep 13, 2023
@matt-primrose matt-primrose moved this from Todo to In Progress in Sprint Planning Sep 14, 2023
Craig-Spencer-12 added a commit that referenced this issue Sep 26, 2023
@rsdmike rsdmike linked a pull request Sep 26, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Feature Backlog Sep 27, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Sprint Planning Sep 27, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 2.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants